TobiasRubel / Pathway-Reconstruction-Tools

2 stars 0 forks source link

ResponseNet writes an intermediate file and takes a new parameter #9

Open annaritz opened 4 years ago

annaritz commented 4 years ago

ResponseNet doesn't fit within the original run_XXX() format. It has a parameter gamma that we should vary, and it writes the linear program to an intermediate file. Where should intermediate files live?

ResponseNet and others don't need a value k passed in.

TobiasRubel commented 4 years ago

Hmm..

You'll probably know better than I how to handle different parameters going to different methods. My intuition is to just add the gamma parameter to all wrappers and then make no use of it for all methods other than ResponseNet. This has the advantage of being incredibly simple to implement. If we have to do it many times however (as in the case that many methods take different hyper-parameters), then the code is going to get really silly.

Currently I expect programs to handle their own intermediate files. For instance, the HybridLinkers just place intermediate files in the same directory that they live in. One issue with placing intermediate files all in the same directory is that the code runs concurrently, and I have a (perhaps irrational) fear that if we aren't careful methods will overwrite one another's temporary files and it will be difficult to identify. This probably is not a problem for ResponseNet. Another issue with placing intermediate files in the same directory is it requires a little more from people putting their code into the repo. On the other hand, having a temporary files folder might clean things up a bit.