TobiasSunderdiek / cartoon-gan

Implementation of cartoon GAN [Chen et al., CVPR18] with pytorch
https://tobiassunderdiek.github.io/cartoon-gan/
MIT License
61 stars 22 forks source link

Error in COCO Dataset #1

Closed tammy3107 closed 4 years ago

tammy3107 commented 4 years ago

The dataset that you have linked in the project is giving errors. I had to download the original dataset from the official site again to make it work. Please look into this matter.

TobiasSunderdiek commented 4 years ago

Thank you for opening this issue, I just tested README-Step 1 to download the coco-data from the reference [3] in README: http://images.cocodataset.org/annotations/annotations_trainval2017.zip. With Google Chrome, download finished with no errors. Can you please provide me some additional information to reproduce the issue? Thanks in advance!

tammy3107 commented 4 years ago

Actually when I downloaded it and tried to open with Coco API it was giving error that 'can't load the annotations then I redownloaded the dataset from the Coco website and it was not giving error

TobiasSunderdiek commented 4 years ago

Thank you, my documentation in https://tobiassunderdiek.github.io/cartoon-gan/#tc1_3 was very misleading, sorry for the circumstances! I will correct it. After downloading and unzipping the annotations, please configure in file cartoon-gan/photo_downloader.py the path where the unzipped annotations folder lies, https://github.com/TobiasSunderdiek/cartoon-gan/blob/master/photo_downloader.py#L7 but only the root-folder of annotations. Example: Download and unzip annotations was to /tmp/annotations/, then please modify the line from "." to "/tmp" (no "annotations" needed") [Edit: I was hitting RETURN to early, was in the middle of writing] [Multiple other Edits: made some better additions to the info I wrote]

TobiasSunderdiek commented 4 years ago

Documentation updated

TobiasSunderdiek commented 4 years ago

I hope this helps to solve your issue?

tammy3107 commented 4 years ago

Yeah thanks a lot

TobiasSunderdiek commented 4 years ago

Great, thank you for helping me making this repo better by having opened this issue!

I'll close it now, best regards