Fix(mssql): change mssql conn_properties type to List

TobikoData / sqlmesh

Efficient data transformation and modeling framework that is backwards compatible with dbt.

https://sqlmesh.com

Apache License 2.0

1.83k stars 161 forks source link

Closed treysp closed 2 days ago

treysp commented 3 days ago

Pydantic v2 or above errors when a value is passed to the conn_properties connection key:

TypeError: cannot pickle 'pydantic_core._pydantic_core.SerializationIterator' object

This PR updates the type from iterable to list, fixing this issue and matching the pymssql typing.

georgesittas commented 3 days ago

FYI @treysp the failing test is probably flaky, see https://github.com/TobikoData/sqlmesh/pull/3404