Add an "int16" property type

Toblerity / Fiona

Fiona reads and writes geographic data files

https://fiona.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

1.14k stars 201 forks source link

Closed sgillies closed 3 months ago

sgillies commented 4 months ago

Resolves #1321

I might like to improve how the project enumerates its data types too.

sgillies commented 4 months ago

@mwtoews any thoughts on this?

mwtoews commented 4 months ago

Sure, some questions / remarks:

Should int16 be described in this doc or specifically fiona.FIELD_TYPES_MAP? (also bool is missing here too, so I'm not entirely sure if this subdata type should be added there.)
Currently fiona.schema.normalize_field_type("int16") returns int32; should it? The same function with bool returns bool.

sgillies commented 4 months ago

@mwtoews thank you! I'll check on the function, that looks like a bug.

sgillies commented 3 months ago

@mwtoews I'm going to address your concerns in a follow up PR.