search

Toblerity / Fiona

Fiona reads and writes geographic data files
https://fiona.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
1.14k stars 201 forks source link

Don't attempt to test append to parquet dataset in test_append_memoryfile_drivers #1394

Closed manisandro closed 2 months ago

manisandro commented 2 months ago

The parquet driver does not appear to support append mode, and opening with mode='a' fails with

fiona._err.CPLE_OpenFailedError: '/vsimem/f66391b5a3ba47bc93363c6b80a15e96/f66391b5a3ba47bc93363c6b80a15e96.parquet' not recognized as being in a supported file format.

Opening in regular write mode succeeds though.

rbuffat commented 2 months ago

@manisandro is this specific to memoryfile or in general? If the Parquet driver does not support append mode, it would be good to change drvsupport.py from raw to rw too.

manisandro commented 2 months ago

For instance here [1] it states that

Once written, a Parquet file is immutable. No modification or appending can happen to that Parquet file. Instead, create a new Parquet file.

So I believe that it applies in general to parquet files. I've updated drvsupport.py accordingly.

[1] https://guide.cloudnativegeo.org/geoparquet/#files-are-immutable