Toblerity / rtree

Rtree: spatial index for Python GIS
https://rtree.readthedocs.io
MIT License
627 stars 123 forks source link

CI/RLS: upgrade to libspatialindex-2.0.0 #316

Closed mwtoews closed 3 months ago

mwtoews commented 4 months ago

Towards #315.

This PR does the following:

hobu commented 4 months ago

Waiting on you to merge this @mwtoews. Should we fire a release afterward?

mwtoews commented 4 months ago

there one thing that I'm sorting out before merge, as I want to keep the linux lib dir in Rtree.libs, since I see downstream packages rely on this.

mwtoews commented 3 months ago

There is yet another big list of changes on the build-side, updated in the PR description. This is ready to review by anyone, I'll probably merge it in another day after I've had a chance to carefully review the artefacts.

EwoutH commented 3 months ago

This looks like an amazing clean-up!

One thing I noticed, is that in the build CI vcpython27 is installed on Windows:

https://github.com/Toblerity/rtree/blob/d42650ccd78a413ce016a8528a859ed8ab20c1ee/.github/workflows/deploy.yml#L43-L47

Is this still needed, or can it be updated?

mwtoews commented 3 months ago

It looks like vcpython27 was added in 2020 with #174, at the time when MSBuild was used. Perhaps the existing ilammy/msvc-dev-cmd is sufficient, since cl.exe is needed for cmake -G Ninja (in ci/install_libspatialindex.bat).