TobyLobster / Inform

Inform is a design system for interactive fiction based on natural language
Other
83 stars 18 forks source link

My modernizations #11

Closed MaddTheSane closed 2 years ago

MaddTheSane commented 2 years ago

This contains a lot of my modernizations, including:

Note that this ups the deployment target to 10.15 10.14, as well as links to my own fork of Zoom (which has a lot of modernizations as well). Also, I've moved some stuff around.

I also rebuilt the inform6 binary as an Apple Silicon/Intel Universal 2 Binary. The other binaries should also be rebuilt to have a native Apple Silicon version.

TobyLobster commented 2 years ago

Hi MaddTheSane, this looks like it could be very useful. Would it be possible to support 10.14 as a deployment target?

MaddTheSane commented 2 years ago

I’ll look into it.

The biggest change needed would be on ZoomView, as I’ve been poking at that longer and have done more work on Zoom as a whole.

MaddTheSane commented 2 years ago

I have set the deployment target to 10.14.

TobyLobster commented 2 years ago

Thanks for allowing the earlier deployment target. I'm keen to look through the changes, but I'm having trouble accessing the submodule. Do you have any ideas?

% git submodule status -24d2fb90690ce8daec798a02d371c8370abd94bc zoom % git pull --recurse-submodules Could not access submodule 'zoom'

My knowledge of submodules in git is slim, so I'm probably doing something wrong.

MaddTheSane commented 2 years ago

git submodule update --init --recursive

MaddTheSane commented 2 years ago

If needed, I can remove the submodule requirement.

TobyLobster commented 2 years ago

Apologies for my long absence @MaddTheSane, everything else got in the way, but I am now back looking at Inform again. I'm looking at your changes and I'm seeing an issue when trying to run stories in the Glulx format (Z-Code version 8 format is working). The story compiles ok, but the story view is just white with no interaction. There are no errors on the system log, or in the Console app. Screenshot 2022-03-31 at 08 36 37

If you have any thoughts on this, I would be interested to know. Thanks.

MaddTheSane commented 2 years ago

I think I found out the issue and fixed it in my personal commit of 5fdde35df09274c358eedca470d9c8548b66d2e4. I'll backport it to this pull request ASAP.

TobyLobster commented 2 years ago

This now seems to be referencing new audio frameworks that I don't have. The File Inspector is saying they are Absolute Path file references:

Build target Inform of project Inform with configuration Debug /Users/tobynelson/Code/InformApp/inform/Inform.xcodeproj: error: This Copy Files build phase contains a reference to a missing file 'Ogg.framework'. (in target 'Inform' from project 'Inform') /Users/tobynelson/Code/InformApp/inform/Inform.xcodeproj: error: This Copy Files build phase contains a reference to a missing file 'SFBAudioEngine.framework'. (in target 'Inform' from project 'Inform') /Users/tobynelson/Code/InformApp/inform/Inform.xcodeproj: error: This Copy Files build phase contains a reference to a missing file 'GlkSound.framework'. (in target 'Inform' from project 'Inform')

MaddTheSane commented 2 years ago

Make sure you do a git submodule update --init --recursive.

TobyLobster commented 2 years ago

Done - but I get the same issue still.

MaddTheSane commented 2 years ago

Did you try closing the project/Xcode and opening it again?

TobyLobster commented 2 years ago

Yes - still no joy.

On 1 Apr 2022, at 08:33, C.W. Betts @.***> wrote:

Did you try closing the project/Xcode and opening it again?

— Reply to this email directly, view it on GitHub https://github.com/TobyLobster/Inform/pull/11#issuecomment-1085534413, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKSJYEOXJOQ5LDPHFOBF6LVC2RDVANCNFSM5ISPU7GQ. You are receiving this because you commented.

MaddTheSane commented 2 years ago

I see the problem. Stupid absolute paths…

TobyLobster commented 2 years ago

:-)

On 1 Apr 2022, at 08:37, C.W. Betts @.***> wrote:

I see the problem. Stupid absolute paths…

— Reply to this email directly, view it on GitHub https://github.com/TobyLobster/Inform/pull/11#issuecomment-1085537350, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKSJYFR6WJBSRGMIQLYUZ3VC2RTDANCNFSM5ISPU7GQ. You are receiving this because you commented.

TobyLobster commented 2 years ago

That works better, thanks.

TobyLobster commented 2 years ago

I want to thank you for your updates. I am working on an update to the Mac App which should be released in a couple of weeks. Your changes are in and working very well locally. Many thanks.

TobyLobster commented 2 years ago

You may have seen that I have submitted all changes back into the Master branch, and released a beta version of the latest App. I am working on writing build instructions for it.

In the meantime, Zarf has implemented the changes required to the Glulxe and Git interpreters for version 3.1.3 of the Glulx specification (mostly, adding the opcodes for double precision maths), and there are now new releases of these interpreters.

Glulxe 0.6.0: https://github.com/erkyrath/glulxe/releases/tag/glulxe-0.6.0 Git 1.3.7 : https://github.com/DavidKinder/Git/releases/tag/v1.3.7

It would be good to update to these if possible, then I could take these and presumably all your latest Zoom work into the macOS Inform App for the proper release?

MaddTheSane commented 2 years ago

I updated my personal branch here with these requests