search

Tochemey / NetCore8583

NetCore8583 is a library that helps parse/read and generate ISO 8583 messages for .NET Core
MIT License
33 stars 21 forks source link

Added .Net 8 support #23

Closed amammes closed 5 months ago

amammes commented 5 months ago

Added .Net 8 target Updated Packages using Nuget Fixed some Assert warnings Changed NetCore8583.Test.Util.TestHexCodec.EncodeDecode to private to avoid xUnit1013 warning

closes #22

Tochemey commented 5 months ago

@amammes please can you try and run the tests on a linux(ubuntu) env?

You may need to update these lines in the ci.yml file:

Honestly I cannot tell. I may check later why the tests failed on the ubuntu box.

amammes commented 5 months ago

Sorry, I don't know how to do that.

By the way in the VS2022 build output window I see "The package NetCore8583.1.1.0 is missing a readme." Shouldn't the version be 2.1.0? As least that's your latest release

Tochemey commented 5 months ago

Sorry, I don't know how to do that.

By the way in the VS2022 build output window I see "The package NetCore8583.1.1.0 is missing a readme." Shouldn't the version be 2.1.0? As least that's your latest release

I will take a look this week. Yeah I think it should be 2.1.0. Let me check that.

Tochemey commented 5 months ago

@amammes I have fixed the issues. I am going to merge it and cut a new release tag. Thanks for the PR. I really appreciate it

amammes commented 5 months ago

Glad to contribute this PR. Now I just need to learn how to use this library. :)

Do you have any sample projects, I've already checked readme.md, and saw some examples there, but if you had a small project that can process a 0100/0110 AUTH message or actually any message pair at all that would be great.

Been writing ISO8583 since prehistory mostly using Verifone C/C++ SDKs. This time I'd like to avoid reinventing the wheel once again since getting ISO to work perfectly is not trivial.