search

ToddMadison / ff-cckwizard

Automatically exported from code.google.com/p/ff-cckwizard
0 stars 0 forks source link

Preferences are not set or locked #42

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
With CCK Wizard 1.3.4 on Firefox 10.0.7esr when I set preferences such as 
"javascript.enabled" to true and select the Lock Preference check box, the user 
can still override it. After a browser restart the user value is used instead 
of the CCK value. Only if the user has not defined the preference value defined 
using CCK is used.

Original issue reported on code.google.com by richard....@gmail.com on 28 Sep 2012 at 8:04

GoogleCodeExporter commented 8 years ago 
Reverting to CCK Wizard 1.3.2 fixed this issue for me.

Original comment by richard....@gmail.com on 28 Sep 2012 at 8:42

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
I just tested CCK Wizard 1.3.5b6 with Firefox 17.0.2esr, and it has this same 
issue. Using CCK Wizard 1.3.2 seems to work fine though.

Original comment by richard....@gmail.com on 10 Jan 2013 at 10:36

GoogleCodeExporter commented 8 years ago 
I just tested CCK 1.3.5b6, created a new XPI that changed the homepage, 
bookmarks, and some other random things, and tested it in Firefox 17.0.2 ESR 
through my usual deployment strategy.  I had no problems getting it to work.

Original comment by nick.mcs...@sacredsf.org on 10 Jan 2013 at 8:14

GoogleCodeExporter commented 8 years ago 
Thanks for the feedback, Nick. I also created a simple CCK using 1.3.5b6 and 
this worked. So I started digging into the source code of my non-functioning 
CCK and I've found the bug. My OrganizationName is set to "xy-3-0" where xy is 
the identifier of my organization. Inside components/cckService.js the function 
is defined:

function xy_3-0CCKService() {}

Notice the underscore and dash in the function name. The manifest seems to use 
the correct function name:

category profile-after-change xy_3-0CCKService @mozilla.org/cck-service-xy-3-0;2

But somehow it doesn't work. Older versions of the CCK Wizard always used 
CCKService as the function name, which is why they worked for me. 

Changing the OrganizationName to "xy-30" makes the function name 
xy_30CCKService and works. 

I guess dashes are not allowed in the fuction name, and the CCK Wizard only 
replaced the first dash. That is the bug I was hitting.

Original comment by richard....@gmail.com on 14 Jan 2013 at 3:29

GoogleCodeExporter commented 8 years ago 
I thought I'd fixed that problem in the past. I'll take a look.

Original comment by mka...@gmail.com on 15 Jan 2013 at 5:18

GoogleCodeExporter commented 8 years ago 
I accounted for 1 dash, but not two. I'll fix this.

Original comment by mka...@gmail.com on 15 Jan 2013 at 1:25

GoogleCodeExporter commented 8 years ago 
New build is up:

http://code.google.com/p/ff-cckwizard/downloads/list

Original comment by mka...@gmail.com on 15 Jan 2013 at 10:51