Toddish / Popup

A barebones, flexible jQuery popup plugin. Designed for developers, it's simple to use but very powerful.
http://docs.toddish.co.uk/popup
MIT License
146 stars 78 forks source link

Auto height depending on content doesn't work #3

Closed adis-io closed 11 years ago

adis-io commented 11 years ago

Auto height depending on content doesn't work

Sorry for my bad english

Toddish commented 11 years ago

Hi,

Can you give me some example code or something?

This is a bit too vague to go off.

Thanks!

adis-io commented 11 years ago

Ok, how I can set height in percent

Toddish commented 11 years ago

Hi,

Sorry, I've had computer issues. Only just back up and running!

You're right, you can't set a percentage height.

I'm not sure how best to implement this, as currently I set the height of the popup, which has a container round it.

To do the percentage properly, we'd need to set it on the container.

Any ideas?

adis-io commented 11 years ago

Hi, I don't know it's right way or not, but we can set .popup_cont { height: 100%}; and .popup { height: 80%}

2013/10/23 Todd Francis notifications@github.com

Hi,

Sorry, I've had computer issues. Only just back up and running!

You're right, you can't set a percentage height.

I'm not sure how best to implement this, as currently I set the height of the popup, which has a container round it.

To do the percentage properly, we'd need to set it on the container.

Any ideas?

— Reply to this email directly or view it on GitHubhttps://github.com/Toddish/Popup/issues/3#issuecomment-26833139 .

Toddish commented 11 years ago

Ah, that's a decent solution to be honest, better than editing the JS.

I'll mark this as closed :)