search

Todoloo-WoW / Todoloo

The Todoloo task manager addon for World of Warcraft
MIT License
1 stars 0 forks source link

Weekly task will renew daily #51

Closed mhx3 closed 2 months ago

mhx3 commented 2 months ago

Version
What version of Todoloo do you have installed?. v11.0.2

Describe the bug
A clear and concise description of what the bug is. I set some tasks under a weekly group, but the tasks will auto renew with daily group. I use Chinese and not sure if local time affects. I copy the tasks from one character to another, in the todoloo.lua. not sure if it makes it happen. Because for some characters, they need to do the same weekly tasks you know.

To Reproduce
Include the steps to reproduce the behavior. I meet this problem at the 2nd day using this addon, and I re-check all the finished tasks. Now they are all un-checked now at the 3rd day. I think they are wrongly auto un-checked, because weekly tasks should renew on Thursday.

Screenshots
If applicable, add screenshots to help explain your problem.

mhx3 commented 2 months ago

I read the ResetManager.lua, and found the following:

local function ShouldResetGroup(group, previousDailyReset, previousWeeklyReset) local lastResetPerformed = Todoloo.Config.Get(Todoloo.Config.Options.LAST_RESET_PERFORMED) if group.reset == TODOLOO_RESET_INTERVALS.Daily and lastResetPerformed < previousDailyReset then -- reset daily groups return true elseif group.reset == TODOLOO_RESET_INTERVALS.Weekly and lastResetPerformed < previousDailyReset then -- reset weekly groups return true end I guess the bold part should be < previousWeeklyReset then

detilium commented 2 months ago

Hi @mhx3

Well spotted. I've fixed the bug and am working on a release right now. And update sohuld be available within 10-15 minutes.

Thank you for your bug report and your debugging ;)