TogAr2 / MinestomPvP

Combat library for Minestom
Apache License 2.0
80 stars 31 forks source link

Add PlayerFishEvent #15

Closed malafk closed 2 years ago

malafk commented 2 years ago

adds playerfishevent which is called when the player retracts the bobber, useful for grappling hook type items and getting the location of the bobber before retract

TogAr2 commented 2 years ago

You seem to have forked from emortal's fork, which contains some changes I do not want in the main repository. If it was your intention to open the pr here, you should open another one without emortal's changes, in which case it would be nice if the event is also called for throwing the fishing bobber. Also the event should be cancellable (use EventDispatcher.callCancellable).