search

Together-100Devs / Together

Together is a group calendar application using the MERN stack intended to bring discord communities closer!
https://together.cyclic.app/
MIT License
167 stars 112 forks source link

Add event success form is displaying even if event was not successful. #320

Closed Caleb-Cohen closed 1 year ago

Caleb-Cohen commented 1 year ago

Describe the bug

Looks like some back-end validation rejections are not also caught on the front end.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Calendar Page
  2. Click on Add event
  3. Add a recurring event with a start date of today but a start time that has already passed. For example if it is 6pm local have the start time to be 5pm.
  4. See error below Screenshot 2023-02-08 at 7 29 51 PM
Screenshot 2023-02-08 at 7 30 08 PM

Expected behavior

Front end should prevent user from getting to the point where they can submit an event that will be rejected OR the validation should be removed. I'd prefer former than the later on this one.

Which Branch should this fix be Pulled into?

PR into development

Device Information

Additional context

Add any other context about the problem here.

If you're interested in working on this feature, please comment so you can be assigned

MatthewBozin commented 1 year ago

Hey Caleb! Since I uncovered several bugs with the front-end form, I went ahead and recomposed this issue as #331, based around rebuilding the front-end form validation. I also listed the various bugs I ran into as possible examples of errors the rebuilt validation should be able to catch.

Caleb-Cohen commented 1 year ago

Hey Caleb! Since I uncovered several bugs with the front-end form, I went ahead and recomposed this issue as #331, based around rebuilding the front-end form validation. I also listed the various bugs I ran into as possible examples of errors the rebuilt validation should be able to catch.

Ok I will close this issue.