search

Together-100Devs / Together

Together is a group calendar application using the MERN stack intended to bring discord communities closer!
https://together.cyclic.app/
MIT License
166 stars 112 forks source link

Build reusable button component to close pop-up modals #334

Open intelagense opened 1 year ago

intelagense commented 1 year ago

Please provide a summary of the feature

Currently, the close buttons are centered at the top of the modals and says close Suggest turning the button into a reusable React component moving the close button to the right side of the modal and turning it into an X icon to match typical expected behavior.

Are there any potential issues you foresee with this feature

Needs to match the styling in #17

Is this feature related to any current or past issues? Please provide the

This was noticed with PR #333 into issue #303

Additional context

Add any other context or screenshots about the feature request here.

Which Branch should this fix be Pulled into?

PR into [development]

If you're interested in working on this feature, please comment so you can be assigned

colinborows commented 1 year ago

interested, please assign.

Caleb-Cohen commented 1 year ago

Hey @colinborows I'm just checking in on this, thank ya!

colinborows commented 1 year ago

Hey! After a slight diversion, I am back on the React grind and working on this issue. I have been learning more about contexts and considering how best to implement this. I will reach out to the team with some questions this week.

colinborows commented 1 year ago

Update - reached a roadblock with this. Will be reaching out for help tomorrow.

Caleb-Cohen commented 1 year ago

Update - reached a roadblock with this. Will be reaching out for help tomorrow.

Sounds good. Did you get the help you were looking for?

luciousmc commented 1 year ago

@colinborows Caleb mentioned you might need some help with this issue. Feel free to reach out to me on discord @brotahman and we can tackle it 😀

colinborows commented 1 year ago

Update on this - @luciousmc has been kind enough to help me out with this over the past few days and figure out the best option. Now moving forward creating a reusable button that takes in an icon and a function, rather than simply a close button.

Caleb-Cohen commented 1 year ago

Update on this - @luciousmc has been kind enough to help me out with this over the past few days and figure out the best option. Now moving forward creating a reusable button that takes in an icon and a function, rather than simply a close button.

Anything we can help ya with?