Together-100Devs / Together

Together is a group calendar application using the MERN stack intended to bring discord communities closer!
https://together.cyclic.app/
MIT License
167 stars 112 forks source link

Add loading indicator #365

Closed romanstetsyk closed 1 year ago

romanstetsyk commented 1 year ago

Please provide a summary of the feature

Sometimes it can take a while for all events to be fetched from the database. A loading indicator would be a nice feature.

Are there any potential issues you foresee with this feature

Is this feature related to any current or past issues? Please provide the

Additional context

Add any other context or screenshots about the feature request here.

together

Which Branch should this fix be Pulled into?

PR into main

If you're interested in working on this feature, please comment so you can be assigned

Caleb-Cohen commented 1 year ago

Great idea!

what are your thoughts on loading events that are in the current month, visualizing, then loading events that are in prior and future months? I believe it should improve performance since most users are just looking at the current month anyways.

romanstetsyk commented 1 year ago

I agree. Loading events for the current month is a good idea. When the user scrolls to another month, only then load more events. The performance will improve as the application grows and more events are created. Also, there's no need to load events from previous months automatically. In any case, having some sort of spinner or skeleton would be nice.

Caleb-Cohen commented 1 year ago

I agree. Loading events for the current month is a good idea. When the user scrolls to another month, only then load more events. The performance will improve as the application grows and more events are created. Also, there's no need to load events from previous months automatically. In any case, having some sort of spinner or skeleton would be nice.

Yes I agree! I'll add an issue for loading.

DevinCLane commented 1 year ago

I'll take a look at this!

jmoldyvan commented 1 year ago

Would it be a different issue to try and find a solution to optimize loading all events?

intelagense commented 1 year ago

Would it be a different issue to try and find a solution to optimize loading all events?

@jmoldyvan there is issue #366 which might be relevant

intelagense commented 1 year ago

https://user-images.githubusercontent.com/18331781/223742818-1eeb474f-1e60-48ba-b502-c3789b7ba142.mp4

I mocked up this "Shimmer" effect... it's a pretty common tactic. Something like this could go in the calendar day cards while waiting for the database to spool up.

Were ya'll thinking of doing something like this or something more unique?

DevinCLane commented 1 year ago

I like this @intelagense

intelagense commented 1 year ago

Together calendar loading screen won't stop after content is loaded

This is occurring on my desktop. @DevinCLane @Caleb-Cohen

DevinCLane commented 1 year ago

good catch @intelagense, fixed it!