Closed Illuztrado closed 1 year ago
Thanks for the write up on tests. The fix is being worked on, but this PR passed on mac and linux.
@Natashka333 can you review the PR to make sure the changes meet specifications?
@Illuztrado , everything looks great! I was a little unsure about the blue color for the sections (since those were in white in Figma), but now that I see it, I think it looks super cool! Thanks for going with your gut on that one. Great Job! Thank you for your contribution!
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. Additionally, please include reasoning if tests have failed.
Type of change
Please select everything applicable. Please, do not delete any lines.
Issue
336
Summary of changes:
Additional comments:
npm run test-frontend
but app functionality seems to work fine; changes seem to have passed the tests when @Caleb-Cohen tried to execute them on their local machineCR
[prettier/prettier]" error on my local machine when executingnpm run dev-concurrent
andnpm run lint
. This seems to fix the issue on my local machine: https://stackoverflow.com/questions/53516594/why-do-i-keep-getting-eslint-delete-cr-prettier-prettierChecklist:
npm run test
and all tests have passed successfully or I have included details within my PR on the failure.npm run lint
and resolved any outstanding errors. Most issues can be solved by executingnpm run format