Closed Blake-Larson closed 1 year ago
LGTM, test/lint both ran success on my computer. Awaiting @Natashka333 approval.
@Blake-Larson thank you for contribution, this looks great! One thing what I would like to change after running, is the borders. Can we do a corner radius of 15 for every sections and nav divs?
Sure thing. I just made the changes to the border-radius for those items and pushed to this pull request. Let me know if anything else needs to be adjusted!
@Blake-Larson Great work!
Description
I have reworked the TailwindCSS classes for the landing page to better align with the web design by Natashka333.
I reverted the custom media query breakpoints to the tailwind defaults. I believe this gives us greater control over the layouts and better aligns with the web design. I left a comment in the tailwindcss.config for beginners to more easily understand breakpoints.
I made various changes to how some elements were spaced out by using Flexbox instead of static dimensions or padding.
I removed some unnecessary divs.
Type of change
Please select everything applicable. Please, do not delete any lines.
Issue
Checklist:
(I was not able to run tests as I have an issue running Cypress on my WSL on Windows. No functionality should be changed.)
npm run test
and all tests have passed successfully or I have included details within my PR on the failure.npm run lint
and resolved any outstanding errors. Most issues can be solved by executingnpm run format