Together-100Devs / Together

Together is a group calendar application using the MERN stack intended to bring discord communities closer!
https://together.cyclic.app/
MIT License
167 stars 112 forks source link

fixed 401: duplicate events in state hook #403

Closed romanstetsyk closed 1 year ago

romanstetsyk commented 1 year ago

Description

This PR prevents adding duplicate events to the state if a recurring event spans more than 1 month.

Type of change

Please select everything applicable. Please, do not delete any lines.

Issue

Checklist:

Caleb-Cohen commented 1 year ago

LGTM, should we add testing to accompany this?

Caleb-Cohen commented 1 year ago

Howdy @romanstetsyk did you get a chance to review my question?

romanstetsyk commented 1 year ago

@Caleb-Cohen I'm sorry, I didn't see your last message. It's a good idea, but I still need to figure out how to write tests in Cypress. It would be great if someone could add tests to this pr or create a separate issue

Caleb-Cohen commented 1 year ago

@Caleb-Cohen I'm sorry, I didn't see your last message. It's a good idea, but I still need to figure out how to write tests in Cypress. It would be great if someone could add tests to this pr or create a separate issue

I'll take it up!