Together-100Devs / Together

Together is a group calendar application using the MERN stack intended to bring discord communities closer!
https://together.cyclic.app/
MIT License
167 stars 112 forks source link

Users can create reoccuring events that never occur. #424

Open intelagense opened 1 year ago

intelagense commented 1 year ago

Describe the bug

It is possible to create a recurring event that never occurs due to an invalid date range.

To Reproduce

Steps to reproduce the behavior:

  1. Open the calendar view
  2. Press the create new event + button on the first day of the week. (must be past today's date)
  3. Create a weekly recurring event for the last day of that week.
  4. Ensure that the start and end dates do not include the weekday of the event.
  5. Click Submit on the confirm section of the modal.
  6. There will be no new events on the calendar, but the form will say you have successfully created the event.

Expected behavior

There should be a validation error if no new events are added to the calendar when clicking submit on the confirm page.

Screenshots

N/A

Additional context

Users might be assuming that recurring events are indefinite. A redesign of the create event modal could help avoid confusion.

MingJae92 commented 1 year ago

Hi there, I am quite new to this could you explain steps 3-6 in more detail please?

intelagense commented 12 months ago

So in this example, the start date is a Monday and the end date is Thursday of the same week but the event is supposed to reoccur weekly on Fridays and Saturdays. The modal would allow me to continue without creating any actual events because the end date is before the first scheduled event. Event creation modal with date picker dates circled

romanstetsyk commented 12 months ago

@intelagense, it's definitely a bug. Nice catch!