Closed cblanken closed 1 year ago
Code looks good. Should we consider additional testing?
For example: insert event into DB, does it visualize?
Looks good so far, what are your thoughts on deleting the event and checking if it no longer exists?
My thinking is that I should be able to send a DELETE to the /event/:id
endpoint and just delete any notes by id
. I might add a Cypress command like deleteOwnEvents
to make it a bit easier to use.
Then the rendering check can loop through any remaining notes and confirm the note with the target id
no longer exists.
I should be able to take a look at it in the next couple days and let you know if I run into any issues with that method.
Looks good so far, what are your thoughts on deleting the event and checking if it no longer exists?
My thinking is that I should be able to send a DELETE to the
/event/:id
endpoint and just delete any notes byid
. I might add a Cypress command likedeleteOwnEvents
to make it a bit easier to use.Then the rendering check can loop through any remaining notes and confirm the note with the target
id
no longer exists.I should be able to take a look at it in the next couple days and let you know if I run into any issues with that method.
That's how I would approach it!
LGTM Thanks for taking this on!
Description
Display all current events on Admin Dashboard. The AdminDashboard page now loads all current events and displays them in a list. The page initially loads all the current events automatically, but any subsequent refreshes must use the "Refresh Events" button in the top right.
NOTE: All tests passed for the first two commits cdd0cd709e3845aaa2c75b2cf391cb8d099b61f8 and cbfaa9fceae3197504fc3cb791d4d5bb3df4c0f5. However, the Admin dashboard cannot currently be accessed while running the development build due to an old
/calendar
redirect inclient/src/contexts/AuthContext/useProvideAuth.js
. The latest commit d6db77b81fcb7002fe28e2e1846341a4d40b7f64 removes this redirect for testing the Admin Dashboard, but some adjustments will need to be made to the relevant failing tests.I've attached test-events.zip with a json file that can be imported into the
events
Mongo collection to test the loading animation with a large set of events.Type of change
Please select everything applicable. Please, do not delete any lines.
Issue
Checklist:
npm run test
and all tests have passed successfully or I have included details within my PR on the failure.npm run lint
and resolved any outstanding errors. Most issues can be solved by executingnpm run format