Together-100Devs / Together

Together is a group calendar application using the MERN stack intended to bring discord communities closer!
https://together.cyclic.app/
MIT License
167 stars 112 forks source link

Keyboard focus rings are not fully visible in landing page header in Chrome #435

Closed intelagense closed 11 months ago

intelagense commented 11 months ago

Describe the bug

When navigating the page using the keyboard it is not possible to see if a link is highlighted in the header section. This is dependent on screen resolution and zoom level and at least affects the Chrome browser. Chrome appears to use a black ring with a white border for the focus ring. This is similar to the existing styles on the links in the header and makes the focus ring difficult to detect visually.

To Reproduce

Steps to reproduce the behavior:

  1. Using Chrome, Go to the Together landing page at https://together.cyclic.app/ (If you are redirected to the calendar view, click the Home button in the top left to go back to the landing page.)
  2. Click on the URL bar in your browser.
  3. Press the tab key repeatedly to cycle through all the site links.
  4. Notice that the top buttons never appear to have a visible focus ring but the other links do.

Expected behavior

Links should have a visible focus ring for accessibility.

Screenshots

Above 100% zoom, there is a barely perceptible white ring around the home button in this screenshot image At 75% zoom, there is a more pronounced black ring on the home button but it is still difficult to see. image

Which Branch should this fix be Pulled into?

PR into main

Device Information

Desktop (please complete the following information):

Additional context

The focus ring for these links could be changed to a more contrasting color or larger size but this change should still be tested on additional browsers before closing the issue.

If you're interested in working on this feature, please comment so you can be assigned

AhmedHHamdy commented 11 months ago

Hey Eric, Can I take this issue ?