Together-100Devs / Together

Together is a group calendar application using the MERN stack intended to bring discord communities closer!
https://together.cyclic.app/
MIT License
167 stars 112 forks source link

Bug/Issue 434 fixed discord and github login link clickable #436

Closed neeravbhaskarla closed 1 year ago

neeravbhaskarla commented 1 year ago

Description

Resolved the issue pertaining to the Discord Login functionality and rectified the GitHub link on the landing page, which was visually resembling a button, but only the text and logo areas were clickable. The resolution entailed relocating the relevant styles within the button or link () element, resulting in full clickability across the entire element.

Type of change

Please select everything applicable. Please, do not delete any lines.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update
  • [ ] This change requires an update to testing

Issue

  • [x] Is this related to a specific issue? If so, please specify: Fixes Issue: #434

Checklist:

  • [x] This PR is up to date with the main branch, and merge conflicts have been resolved
  • [x] I have executed npm run test and all tests have passed successfully or I have included details within my PR on the failure.
  • [x] I have executed npm run lint and resolved any outstanding errors. Most issues can be solved by executing npm run format
  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] My changes generate no new warnings
Caleb-Cohen commented 1 year ago

Hey there. Can you tell me why the button wasn't clickable? Trying to understand from a testing perspective.

intelagense commented 1 year ago

@Caleb-Cohen Drake meme showing clicked areas described in issue #454 Only the inner text areas were clickable. The click event didn't wrap the parent container which I believe is a div styled up like a button.