Together-100Devs / Together

Together is a group calendar application using the MERN stack intended to bring discord communities closer!
https://together.cyclic.app/
MIT License
167 stars 112 forks source link

Protect users from accessing `/adminDashboard` #439

Open Caleb-Cohen opened 11 months ago

Caleb-Cohen commented 11 months ago

Please provide a summary of the feature

Currently admin dashboard can be access using React Router by appending /adminDashboard to the end. We want to prevent users from access adminDashboard. Ideally, it blocks the user on request instead of redirecting them once they land on the page.

Depends on

441

Is this feature related to any current or past issues? Please provide the

Additional context

This is a tough cookie. React router seems a little restrictive with our options considering the current app design.

Add any other context or screenshots about the feature request here.

If you're interested in working on this feature, please comment so you can be assigned

cblanken commented 11 months ago

I'd like to take another look at this, but if I haven't gotten anywhere by the weekend, someone should feel free to pick it up.

r-Dev03 commented 11 months ago

When you say "block them" what are you exactly referring to? Do you mean send them to a page that notifies them that only admin's can access that page? That would be considered some form of "blocking"

Caleb-Cohen commented 10 months ago

When you say "block them" what are you exactly referring to? Do you mean send them to a page that notifies them that only admin's can access that page? That would be considered some form of "blocking"

I've kept it vague as I'm not familiar with all our options. Ideally, un-authorized users will not have access to the /Admindashboard page. Any attempt to access will redirect back to homepage, without accessing any part of the page.

r-Dev03 commented 10 months ago

Hmm, sounds good, I can take a crack at it if don't mind assigning me

Caleb-Cohen commented 10 months ago

Hmm, sounds good, I can take a crack at it if don't mind assigning me

assigned!

Caleb-Cohen commented 10 months ago

On hold for #441