Closed cblanken closed 1 year ago
Here are a couple screenshots
Admin Dashboard with 1 single event and 1 recurring event.
Recurring event on calender
Just curious why this was added. Did we not have this functionality?
Otherwise, LGTM
Before, repeating events were rendered individually for each instance. According to issue #413 it was requested to group recurring events into individual items which this PR addresses.
Just curious why this was added. Did we not have this functionality? Otherwise, LGTM
Before, repeating events were rendered individually for each instance. According to issue #413 it was requested to group recurring events into individual items which this PR addresses.
Sorry I was referencing a code block that didn't carry over to the comment. I'm surprised we did not have the functionality referenced below in
cypress/support/commands.js
Cypress.Commands.add("deleteOwnEvent", id => {
if (id) {
cy.request("DELETE", `/events/${id}`);
}
});
Cypress.Commands.add("getAllEvents", userCode => {
// cy.login(userCode)
return cy.request("GET", "/events");
});
Not that I could find. There were only Cypress commands for login
, createOwnEvents
, and deleteOwnGroupEvents
, so I added those to avoid a bunch of code duplication in the tests.
Description
Group repeating events with the same
groupId
into a single items on the admin dashboard and split single (non-repeating) events and repeating events into separate sections.Type of change
Please select everything applicable. Please, do not delete any lines.
Issue
This PR addresses issue #413
Checklist:
npm run test
and all tests have passed successfully or I have included details within my PR on the failure.npm run lint
and resolved any outstanding errors. Most issues can be solved by executingnpm run format