Together-100Devs / Together

Together is a group calendar application using the MERN stack intended to bring discord communities closer!
https://together.cyclic.app/
MIT License
167 stars 112 forks source link

Feature/admin dashboard visualize group events 413 #448

Closed cblanken closed 1 year ago

cblanken commented 1 year ago

Description

Group repeating events with the same groupId into a single items on the admin dashboard and split single (non-repeating) events and repeating events into separate sections.

Type of change

Please select everything applicable. Please, do not delete any lines.

Issue

This PR addresses issue #413

Checklist:

cblanken commented 1 year ago

Here are a couple screenshots

Admin Dashboard with 1 single event and 1 recurring event. image

Recurring event on calender image

cblanken commented 1 year ago

Just curious why this was added. Did we not have this functionality?

Otherwise, LGTM

Before, repeating events were rendered individually for each instance. According to issue #413 it was requested to group recurring events into individual items which this PR addresses.

Caleb-Cohen commented 1 year ago

Just curious why this was added. Did we not have this functionality? Otherwise, LGTM

Before, repeating events were rendered individually for each instance. According to issue #413 it was requested to group recurring events into individual items which this PR addresses.

Sorry I was referencing a code block that didn't carry over to the comment. I'm surprised we did not have the functionality referenced below in

cypress/support/commands.js


Cypress.Commands.add("deleteOwnEvent", id => {
  if (id) {
    cy.request("DELETE", `/events/${id}`);
  }
});

Cypress.Commands.add("getAllEvents", userCode => {
  // cy.login(userCode)
  return cy.request("GET", "/events");
});
cblanken commented 1 year ago

Not that I could find. There were only Cypress commands for login, createOwnEvents, and deleteOwnGroupEvents, so I added those to avoid a bunch of code duplication in the tests.