Together-100Devs / Together

Together is a group calendar application using the MERN stack intended to bring discord communities closer!
https://together.cyclic.app/
MIT License
167 stars 112 forks source link

Made the calendar page mobile-responsive #450

Closed devlarabar closed 8 months ago

devlarabar commented 10 months ago

Description

The calendar page is now mobile-responsive; the issue before this change was that the calendar header was too wide, and was not resizing properly when the screen size changed. Using only Tailwind CSS, this has been fixed. Please see the screenshots below for examples of what the header now looks like at different breakpoints!

Screenshot 2023-08-28 134434 Screenshot 2023-08-28 134530 Screenshot 2023-08-28 134604 Screenshot 2023-08-28 134622 Screenshot 2023-08-28 134643

Type of change

Please select everything applicable. Please, do not delete any lines.

Issue

Checklist:

cblanken commented 10 months ago

This looks great. I like the more compact header for mobile.

One thing I did notice is that the EventModal popup is pretty cramped when in mobile dimensions. image image

We probably want to make it fullscreen once we get to smaller form factors like this image

Looking at the code though it looks like it gets kinda messy. We'll need to rework the styles in UserForm.js, EventModal.jsx, CalendarPage.js and Backdrop.jsx so I don't know if we'd want to include that in this PR as part of the calendar page or just make a separate issue for the modals.

@Caleb-Cohen thoughts?

Caleb-Cohen commented 10 months ago

This looks great. I like the more compact header for mobile.

One thing I did notice is that the EventModal popup is pretty cramped when in mobile dimensions. image image

We probably want to make it fullscreen once we get to smaller form factors like this image

Looking at the code though it looks like it gets kinda messy. We'll need to rework the styles in UserForm.js, EventModal.jsx, CalendarPage.js and Backdrop.jsx so I don't know if we'd want to include that in this PR as part of the calendar page or just make a separate issue for the modals.

@Caleb-Cohen thoughts?

While I agree it could really benefit from some style love, I think this is out of scope for what @devlarabar originally signed up for and what I approved.

cblanken commented 10 months ago

While I agree it could really benefit from some style love, I think this is out of scope for what @devlarabar originally signed up for and what I approved.

Fair enough. I'll write up a separate issue to address the mobile-responsive styling for the modals.

Caleb-Cohen commented 10 months ago

While I agree it could really benefit from some style love, I think this is out of scope for what @devlarabar originally signed up for and what I approved.

Fair enough. I'll write up a separate issue to address the mobile-responsive styling for the modals.

Agreed. Will you be at standup on Tuesday to discuss this as well?

cblanken commented 10 months ago

Yep I'll be there 👍