Together-100Devs / Together

Together is a group calendar application using the MERN stack intended to bring discord communities closer!
https://together.cyclic.app/
MIT License
167 stars 112 forks source link

Add React Router Page Structure #56

Closed MatthewBozin closed 1 year ago

MatthewBozin commented 1 year ago

This is an issue representing task 4 of issue #29

Add a React Router for routing between/adding new pages so that other collaborators would be able to add new pages with minimal setup.

Caleb-Cohen commented 1 year ago

Added to project board. Can you clarify a bit? I don't think I understand what this is doing.

MatthewBozin commented 1 year ago

I've expanded this a bit for clarity. Do you have any questions in particular?

Caleb-Cohen commented 1 year ago

Clarification helped with the first two, thanks for the link. Is Number 3 a guide to show people how to make new pages?

MatthewBozin commented 1 year ago

Re: number 3: Yes exactly! I'll rephrase the issue so it's more clear.

ghost commented 1 year ago

Deprecated / No longer relevant.

MatthewBozin commented 1 year ago

@WinstonHall how is this deprecated?

ghost commented 1 year ago

We wont be using react-router, at least not what next gives us. unless they use react router dom under the hood. I hastily misread React Router for ReactRouterDom, and the third bullet point In the original post that's gonna be outline for us by design.

So maybe I should have said something like, could be updated at some point to fit our direction now.

Caleb-Cohen commented 1 year ago

@WinstonHall There has not been a decision on Next yet. Can you post your Next template into discussions?

ghost commented 1 year ago

@Caleb-Cohen
First question, the answer is do you want me to do it, if so I can start getting ready for that now while I coffee up.

  Second question, I wasn't sure if we was going to be waiting for a definitive decision on Next or not. 
        Soooooo with that in mind if I'm gonna mess with Next I would like to be sure this time. I thought
        we came to some kind of agreement , I forget who all was there but I really didn't know the implication
        of how many people where actually considered actively involved. 

  I just need to have a green light, I'm gun shy now after that assumption I made yesterday lol.
ghost commented 1 year ago

Commenting to elevate that this is stalled mostly due to not being sure if we are going to use a font & back end separated strategy or Next. Honestly I'm good getting around still to at least see the states work and all the components that dont live in auth territory.

Caleb-Cohen commented 1 year ago

Commenting to elevate that this is stalled mostly due to not being sure if we are going to use a font & back end separated strategy or Next. Honestly I'm good getting around still to at least see the states work and all the components that dont live in auth territory.

I think this will be a good discussion for Thursday, but you are right it is stalled because we have yet to make a decision on the direction.

Caleb-Cohen commented 1 year ago

@WinstonHall can I assign you to see if we can make react router work for this? Let's talk on Thursday and see your thoughts.

ghost commented 1 year ago

In that environment, though my brain is fried I almost feel confident that it won't work or it will do even better and shit the bed because of how we have to wrap the react.

ghost commented 1 year ago

Has this topic changed any? Can we assume it can be written in a front-end way, or have we decided if this will be a server side rendered thing?

ghost commented 1 year ago

If we deploy the front and back separately then I would suggest react-router-dom. I haven't had the time or need to learn their current version v6 https://reactrouter.com/en/main, but I'm familiar with their previous version v5 https://v5.reactrouter.com/web/guides/quick-start.

They have a node solution in in the more current version, but I'm not use to doing routing in the back-end outside of using Next.JS.

Caleb-Cohen commented 1 year ago

@MatthewBozin @WinstonHall closing this issue due to no longer needed.