Open firasrg opened 1 month ago
I don't have time to do a review, so I'll just write here. There are two problems :
assertEquals(sendEval("2+2"), new JShellResult(...))
"var list = List.of(1, 2, 3)"
and then send a separate eval like "println(list)"
Hello @Alathreon !
Your test is too complicated to test something too simple
I think that my test code is pretty simple, it uses WebTestClient API to establish test in a smooth way (ig it's a good practice as mentioned in spring docs) :
create methods or classes for this so your test can be as simple as for example assertEquals(sendEval("2+2"), new JShellResult(...))
I'm not certain i understand this sorry, can u elaborate ?
Pull-request
Changes
Description
This PR is about setting up a first working integration test for JShellAPI only, it contains the following :
POST/jshel/eval
.Note: this PR is about setting the roadmap for testing strategy for JShellAPI only. It doesn't close the relevant issue.