Together-Java / JShellPlaygroundBackend

GNU General Public License v3.0
2 stars 2 forks source link

[JShellAPI][Testing] Setting up First Integration Test - Simple code snippet evaluation scenario #50

Open firasrg opened 1 month ago

firasrg commented 1 month ago

Pull-request

Changes

Description

This PR is about setting up a first working integration test for JShellAPI only, it contains the following :

Note: this PR is about setting the roadmap for testing strategy for JShellAPI only. It doesn't close the relevant issue.

Alathreon commented 2 weeks ago

I don't have time to do a review, so I'll just write here. There are two problems :

firasrg commented 2 weeks ago

Hello @Alathreon !

Your test is too complicated to test something too simple

I think that my test code is pretty simple, it uses WebTestClient API to establish test in a smooth way (ig it's a good practice as mentioned in spring docs) :

create methods or classes for this so your test can be as simple as for example assertEquals(sendEval("2+2"), new JShellResult(...))

I'm not certain i understand this sorry, can u elaborate ?