Together-Java / TJ-Bot

TJ-Bot is a Discord Bot used on the Together Java server. It is maintained by the community, anyone can contribute.
https://togetherjava.org
GNU General Public License v3.0
100 stars 87 forks source link

Modification of discriminator #1002

Closed doshgo closed 7 months ago

doshgo commented 9 months ago

Pull-request

Changes

resolves #867

Description

Invalid discriminator(#0000) shown for users with new username system in uploaded gist by TJ-Bot.

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

ankitsmt211 commented 9 months ago

Hi, can you also add a screenshot in description after changes? thanks usually it's a good idea to add something visual, but it's just one line so it's alright.

doshgo commented 9 months ago

Here's an image of what the change will look like. There is an additional space between the @ and though I am not sure its necessary. What do you guys think? Screen-Shot-2024-01-11-at-7-20-39-PM

ankitsmt211 commented 9 months ago

Here's an image of what the change will look like. There is an additional space between the @ and though I am not sure its necessary. What do you guys think? Screen-Shot-2024-01-11-at-7-20-39-PM

is it after you used getName? you don't need to use @ now. It should look like Uploaded by idkwhatimdoin

doshgo commented 9 months ago

@ankitsmt211 The file below is using : description("Uploaded by " + event.getAuthor().getName());

https://github.com/Together-Java/TJ-Bot/assets/34873349/3475bed6-87ea-4f5c-a027-cc949f429497)

What else needed to be improved?

ankitsmt211 commented 9 months ago

@ankitsmt211 The file below is using : description("Uploaded by " + event.getAuthor().getName());

https://github.com/Together-Java/TJ-Bot/assets/34873349/3475bed6-87ea-4f5c-a027-cc949f429497)

What else needed to be improved?

seems alright, you can push the changes.

ankitsmt211 commented 8 months ago

@doshgo are you still working on this? any update, it's been a month old now.

vishv843 commented 7 months ago

Hi, I wanna work on this. Can you assign the issue to me?

vishv843 commented 7 months ago

image This is an image showing the change.

vishv843 commented 7 months ago

Please check out my PR #1050

ankitsmt211 commented 7 months ago

1050 already merged which targets the same issue, closing this one now.