SquidXTV
commented
8 months ago I just checked for the ping command and it seems like that it fails because of this:
UnaryOperator<SlashCommandInteractionEvent> mockOperator = event -> {
SlashCommandInteractionEvent SlashCommandInteractionEvent = spy(event);
mockInteraction(SlashCommandInteractionEvent);
return SlashCommandInteractionEvent;
};especially the spy(event).
java.lang.IllegalArgumentException: Please don't pass mock here. Spy is not allowed on mock.
at org.mockito.Mockito.spy(Mockito.java:2188)
at org.togetherjava.tjbot.jda.JdaTester.lambda$createSlashCommandInteractionEvent$0(JdaTester.java:248)
at org.togetherjava.tjbot.jda.SlashCommandInteractionEventBuilder.spySlashCommandEvent(SlashCommandInteractionEventBuilder.java:256)
at org.togetherjava.tjbot.jda.SlashCommandInteractionEventBuilder.build(SlashCommandInteractionEventBuilder.java:250)
at org.togetherjava.tjbot.features.basic.PingCommandTest.triggerSlashCommand(PingCommandTest.java:19)
at org.togetherjava.tjbot.features.basic.PingCommandTest.pingRespondsWithPong(PingCommandTest.java:35)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)It seems like it's already a Mock and thus is an illegal argument here. If you check source:
if (MockUtil.isMock(object)) {
throw new IllegalArgumentException("Please don't pass mock here. Spy is not allowed on mock.");
}For me it seems like that the spy() is applied twice:
private SlashCommandInteractionEvent spySlashCommandEvent(String jsonData) {
SlashCommandInteractionEvent event = spy(new SlashCommandInteractionEvent(jda, 0,
new SlashCommandInteractionImpl(jda, DataObject.fromJson(jsonData))));
event = mockOperator.apply(event);What should I do to fix this?
What is even the usage of mockOperator? It seems like that the mockInteraction() method needs it to be a mock, so is this a good idea to do:
UnaryOperator<SlashCommandInteractionEvent> mockOperator = event -> {
if (!MockUtil.isMock(event)) {
event = spy(event);
}
mockInteraction(event);
return event;
};
it would fix all tests. :D
Taz03
dependabot[bot]
sonarcloud[bot]
No data about Coverage
Bumps org.mockito:mockito-core from 5.3.1 to 5.10.0.
Release notes
Sourced from org.mockito:mockito-core's releases.
... (truncated)
Commits
7e1bae8Bump org.shipkit:shipkit-auto-version from 1.2.2 to 2.0.2 (#3248)cf89d49Bump org.assertj:assertj-core from 3.25.1 to 3.25.2 (#3247)cc2ca36Bump org.shipkit:shipkit-changelog from 1.2.0 to 2.0.1 (#3245)ed01de6Bump com.diffplug.spotless from 6.24.0 to 6.25.0 (#3244)ef3dc8fImprove typing for PluginLoader#loadPlugin(..) (#3242)33dc48cBump com.github.ben-manes.versions from 0.50.0 to 0.51.0 (#3241)9173522Add support for static mocks on DoNotMockEnforcer (#3220)a021436Bump com.diffplug.spotless from 6.23.3 to 6.24.0 (#3236)e4fa639Align Javadoc configuration to Java 21 standards (#3230)71e2fdbBump org.gradle.toolchains.foojay-resolver-convention (#3234)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show