search

Together-Java / TJ-Bot

TJ-Bot is a Discord Bot used on the Together Java server. It is maintained by the community, anyone can contribute.
https://togetherjava.org
GNU General Public License v3.0
100 stars 83 forks source link

fixed dismiss buttons #1065

Closed Taz03 closed 4 months ago

Taz03 commented 4 months ago

after the latest jda-upgrade, deleting self message gives "Unkown Webhook" Error, to fix we first need to defer reply to the event

replacing getMessage().delete() with deferEdit().deleteOriginal() in

ankitsmt211 commented 4 months ago

could you brief what was the issue and how are we solving it? thanks

Taz03 commented 4 months ago

@ankitsmt211 after the latest jda-upgrade, deleting self message gives "Unkown Webhook" Error, to fix we first need to defer reply to the event

ankitsmt211 commented 4 months ago

@Taz03 it seems getMessage.delete is present in other commands as well, assuming it would lead to issues there too? some of the test cases also has it

couple of em i could find

Taz03 commented 4 months ago

blocked by #1062

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud