search

Together-Java / TJ-Bot

TJ-Bot is a Discord Bot used on the Together Java server. It is maintained by the community, anyone can contribute.
https://togetherjava.org
GNU General Public License v3.0
100 stars 83 forks source link

upgrade to java 22 #1071

Open Taz03 opened 4 months ago

Taz03 commented 4 months ago
SquidXTV commented 4 months ago

The workflows cannot be on Java 22, because gradle itself doesn't support Java 22 it only supports running code on Java 22.

This is from gradle release notes:- image

but compiling to java 22 works fine right? just not running the daemon with java 22, right?

Taz03 commented 4 months ago

@SquidXTV Yes, compiling works fine. That's why the tests pass

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

SquidXTV commented 4 months ago

Blocked at least until Adoptium offers Java 22 on the main page (i.e. after official release).

It does right? https://adoptium.net/temurin/releases/?version=22

SimonVerhoeven commented 3 months ago

It would be nice to see this one merged.

SquidXTV commented 1 month ago

gradle 8.8 released so this can be finished

Taz03 commented 1 month ago

blocked by #1123

Taz03 commented 1 month ago

Issue related to sonarlint failing https://community.sonarsource.com/t/java-21-unamed-pattern-error/109839

SquidXTV commented 1 month ago

Issue related to sonarlint failing https://community.sonarsource.com/t/java-21-unamed-pattern-error/109839

It is talking about preview features and java 21. How is this related?

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)
19 New Blocker Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint