search

Together-Java / TJ-Bot

TJ-Bot is a Discord Bot used on the Together Java server. It is maintained by the community, anyone can contribute.
https://togetherjava.org
GNU General Public License v3.0
101 stars 87 forks source link

Note command lacks safety checks in onSlashCommand like BanCommand #1085

Closed SimonVerhoeven closed 5 months ago

SimonVerhoeven commented 5 months ago

Describe the bug Note command lacks safety checks in onSlashCommand like BanCommand

Expected behavior For the checks to be present

To Reproduce

Screenshots

Additional context

ankitsmt211 commented 5 months ago

shouldn't we use discord's inbuilt required arguement instead? It would educate the user and stop the command from execution.

SimonVerhoeven commented 5 months ago

In the AddOption they're already marked as required true to educate the user, but the handling (onSlashCommand) was inconsistent.