search

Together-Java / TJ-Bot

TJ-Bot is a Discord Bot used on the Together Java server. It is maintained by the community, anyone can contribute.
https://togetherjava.org
GNU General Public License v3.0
98 stars 82 forks source link

Fix: Pinned Threads Archiving Issue #1084 #1104

Closed JayBhensdadia closed 1 month ago

JayBhensdadia commented 2 months ago

This pull request solves the problem outlined in issue #1084, where pinned threads in the "questions" forum were being archived by the auto-archiving routine.

Testing: For testing purposes i used SCHEDULE_MINUTES = 1 and ARCHIVE_AFTER_INACTIVITY_OF = 100 seconds

Screenshots:

before PR

After INACTIVITY

after PR

Screen recording of test

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

Taz03 commented 2 months ago

A fix for this is already merged ( #1088 )

SimonVerhoeven commented 2 months ago

Ideally first look if a ticket's already assigned, and whether there's already an open pull request for it.

JayBhensdadia commented 2 months ago

Okay, thanks I got it. It was my first contribution.

ankitsmt211 commented 1 month ago

@JayBhensdadia Hi, will be closing this PR soon unless you any further questions.

JayBhensdadia commented 1 month ago

No, I don't have any questions You can close it. Thanks!

ankitsmt211 commented 1 month ago

sweet, hope to see you around :)