search

Together-Java / TJ-Bot

TJ-Bot is a Discord Bot used on the Together Java server. It is maintained by the community, anyone can contribute.
https://togetherjava.org
GNU General Public License v3.0
98 stars 82 forks source link

Fix: Remove pinned eclipse jdt formatter Resolves #605 #1105

Closed thrashy closed 1 month ago

thrashy commented 2 months ago

Fix: Resolves https://github.com/Together-Java/TJ-Bot/issues/605

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

ankitsmt211 commented 1 month ago

@marko-radosavljevic you mind looking into the fix?

marko-radosavljevic commented 1 month ago

Thanks for your first contribution @thrashy. Welcome to the project :relaxed: :heart:

Not sure what introduced these changes, ideally upinning the formatter version doesn't change our formatting at all, but changes themselves are not bad. Finally unpinning the formatter has a lot of benefits on it's own, so I'm fine with it.

I just dislike incosistencies with formattig, and whole point of spotless automatization and formattig configuration was to have deterministic formatting, exactly how we want it, full cotrol to modify the behaviour. This is kinda not that, we just go with the flow what spotless spits out, because configuring it is not trivial.

Also not sure if it fixes the original reason we pinned the version in the first place, with that Token record, so our config might still have some issues. But that part of the codebase is refactored, so let's merge this and see how it goes.