Closed amindadgar closed 2 months ago
The changes streamline the fetch_all
method in fetch_discord_platforms.py
by directly assigning values from the metadata
field to the platform_data
dictionary and update related tests accordingly. This ensures a simpler and more efficient data extraction process, improving code clarity and maintainability.
File Path | Change Summary |
---|---|
dags/analyzer_helper/discord/fetch_discord_platforms.py |
Simplified data extraction by directly assigning period and guild_id from metadata to platform_data . |
dags/analyzer_helper/tests/integration/test_integration_fetch_discord_platforms.py |
Adjusted test data dictionaries, adding guild_id and rearranging fields. |
dags/analyzer_helper/tests/unit/test_unit_fetch_discord_platforms.py |
Removed unnecessary commented-out metadata fields in test dictionaries, retaining key fields. |
In the code where data flows,
We simplified and let it show.
Tests align, fields in place,
Guilds and periods set in grace.
A rabbit's touch, a cleaner space,
Fetching data with a swift pace.
🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
the return values were in wrong structure.
Summary by CodeRabbit
New Features
guild_id
andperiod
from metadata.Tests