Closed amindadgar closed 3 weeks ago
[!CAUTION]
Review failed
The head commit changed during the review from e747b908eb62342b14a021524159263cc70b9e48 to ccf7d08efb0a9fdb1208dec56924c9eaa2f1a5e5.
The changes involve modifications to the ExtractMessages
class in the messages.py
file, specifically updating the query logic to exclude banned users when retrieving messages from the Neo4j database. A new WHERE NOT EXISTS
clause is introduced to filter out authors with a BANNED
relationship. Additionally, a new test method, test_exract_single_banned_user
, is added to the TestExtractTelegramMessages
class in the test file, which verifies that the extractor correctly handles scenarios involving banned users.
File | Change Summary |
---|---|
dags/hivemind_etl_helpers/src/db/telegram/extract/messages.py | Modified extract method in ExtractMessages class to use MATCH and exclude banned users. |
dags/hivemind_etl_helpers/tests/integration/test_extract_messages.py | Added test_exract_single_banned_user method to test extraction behavior with banned users. |
In the garden where messages flow,
A banished user, no longer to show.
With queries refined, the truth we now seek,
Only the welcome, no banned ones to peek.
Hopping through tests, we cheerfully play,
For a cleaner extract, hip-hip-hooray! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Summary by CodeRabbit
New Features
Tests