TogetherCrew / airflow-dags

1 stars 1 forks source link

fix: hivemind telegram ETL, data types and timestamp conversion! #317

Closed amindadgar closed 6 days ago

amindadgar commented 6 days ago

Summary by CodeRabbit

coderabbitai[bot] commented 6 days ago

[!WARNING]

Rate limit exceeded

@amindadgar has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
📥 Commits Reviewing files that changed from the base of the PR and between a96c9f82f0dc92880224c0e16e7b60501927ebf9 and 07d6ca79978f1cc61ea8681889c444bf3acb88d4.

Walkthrough

The pull request modifies the ExtractMessages, ExtractMessagesDaily, and several related classes by changing the chat_id parameter type from str to int in their constructors. Additionally, the ExtractMessagesDaily class updates the logic for handling message timestamps, now treating them as seconds instead of milliseconds. Corresponding changes are made in the unit tests to reflect these updates. The create_telegram_dag function also sees enhancements with the introduction of a msg_count variable for improved logging of extracted messages. The overall focus is on data type consistency and clarity in message extraction processes.

Changes

File Change Summary
dags/hivemind_etl_helpers/src/db/telegram/extract/messages.py Changed chat_id parameter type from str to int in ExtractMessages constructor.
dags/hivemind_etl_helpers/src/db/telegram/extract/messages_daily.py Changed chat_id parameter type from str to int in ExtractMessagesDaily constructor; updated message date extraction logic to use seconds.
dags/hivemind_etl_helpers/tests/unit/test_telegram_extract_daily_messages.py Updated chat_id from string to integer in TestExtractMessagesDaily; adjusted timestamps in tests to reflect seconds instead of milliseconds.
dags/hivemind_telegram_etl.py Introduced msg_count variable for logging extracted message counts; updated related logging statements.
dags/analyzer_helper/telegram/extract_raw_data.py Changed chat_id parameter type from str to int in ExtractRawInfo constructor.
dags/analyzer_helper/telegram/extract_raw_members.py Changed chat_id parameter type from str to int in ExtractRawMembers constructor.
dags/analyzer_helper/telegram/tests/integration/test_telegram_extract_raw_members.py Updated chat_id from string to integer in TestExtractRawMembers class.
dags/hivemind_etl_helpers/src/db/telegram/utils/platform.py Changed chat_id parameter type from str to int in TelegramPlatform constructor.

Possibly related PRs

🐰 In the land of code, where messages flow,
A change in chat_id helps data to grow.
From strings to integers, we make our way,
With clearer logs to brighten the day.
Timestamps in seconds, oh what a delight,
Our rabbit code hops, ready for flight! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.