search

TogetherOS / cicada

🚀 Fast lightweight HTTP service framework.
https://crossoverjie.top/categories/cicada/
Apache License 2.0
953 stars 212 forks source link

#23 Modify getCicadaAction and getCicadaInterceptor.Enhance readabili… #26

Closed binarytom closed 5 years ago

binarytom commented 5 years ago

修改了getCicadaAction和getCicadaInterceptor方法，减少cls.getAnnotation()调用次数，去掉遍历判断annotation的步骤，提高了性能和可读性。

crossoverJie commented 5 years ago

@chosenboy

不好意思，我在下一版本的时候修改了类名结果合并代码时合漏了，请在这个类上重新提交一次 PR 吧，谢谢。

直接提到 master 即可。

https://github.com/TogetherOS/cicada/blob/master/cicada-core/src/main/java/top/crossoverjie/cicada/server/reflect/ClassScanner.java

binarytom commented 5 years ago

哦，行，那我今晚重新提一个PR。fix分支？

原始邮件 发件人:crossoverJienotifications@github.com 收件人:TogetherOS/cicadacicada@noreply.github.com 抄送:chosen boylieh_666@foxmail.com; Mentionmention@noreply.github.com 发送时间:2018年11月14日(周三) 18:10 主题:Re: [TogetherOS/cicada] #23 Modify getCicadaAction and getCicadaInterceptor.Enhance readabili… (#26)

@chosenboy 不好意思，我在下一版本的时候修改了类名结果合并代码时合漏了，请在这个类上重新提交一次 PR 吧，谢谢。 https://github.com/TogetherOS/cicada/blob/master/cicada-core/src/main/java/top/crossoverjie/cicada/server/reflect/ClassScanner.java — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

crossoverJie commented 5 years ago

直接提到 master 即可。

On 11/14/2018 18:17，chosen boy<notifications@github.com> wrote：

哦，行，那我今晚重新提一个PR。fix分支？

原始邮件 发件人:crossoverJienotifications@github.com 收件人:TogetherOS/cicadacicada@noreply.github.com 抄送:chosen boylieh_666@foxmail.com; Mentionmention@noreply.github.com 发送时间:2018年11月14日(周三) 18:10 主题:Re: [TogetherOS/cicada] #23 Modify getCicadaAction and getCicadaInterceptor.Enhance readabili… (#26)

@chosenboy 不好意思，我在下一版本的时候修改了类名结果合并代码时合漏了，请在这个类上重新提交一次 PR 吧，谢谢。 https://github.com/TogetherOS/cicada/blob/master/cicada-core/src/main/java/top/crossoverjie/cicada/server/reflect/ClassScanner.java — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

—You are receiving this because you modified the open/close state.Reply to this email directly, view it on GitHub, or mute the thread.