TohLiYuan / pe

0 stars 0 forks source link

Possible to add non-existent dates #5

Open TohLiYuan opened 11 months ago

TohLiYuan commented 11 months ago

You can add non-existent dates when adding an interview.

Input command: adda /name App4 /phone 10293091 /interview 31/2/2023 1500

However, the date will be amended to the last day of the month. In this case, 28th February instead.

image.png

Should this output an error message to remind the user of potential date mismatch instead?

soc-pe-bot commented 11 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Interview time format

While the UG states a strict limitation on the time format 01/01/2000 0000 and 31/12/9999 0000, it does not enforce any rules on the number of days a month can have.

As such, inputs such as 30/02/2023 1200 or 31/04/2023 1400 are simply rounded down to the nearest day in the month. Users could easily have a typo in their input and not realise their mistake since the application does not reject their input.

However, I think this error is relatively uncommon and that this does not break the application in any severe way, thus a low severity.


[original: nus-cs2103-AY2324S1/pe-interim#1294] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the report. In the current implementation, inputs such as 30/2/2000 will be rounded down to the neared valid date (in this case, 29/2 is valid as 2000 is a leap year). If the user were to follow dates in the real world, it is highly unlikely that they would make a typo of 30, and as such this is a corner case that is not important to handle in v1.4. In fact, some users might find this feature convenient in correcting their the typo. As this does not break the application in anyway, we have decided to label this as NotInScope.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]