nus-pe-bot
commented
2 years ago Team's Response
GitHub usernames are provided by students. Checks are manually done by tutors, and hence this feature is not in scope for our app. Having unique emails and student numbers is sufficient to let us know whether a student is unique.
Items for the Tester to Verify
:question: Issue response
Team chose [response.NotInScope]
- [x] I disagree
Reason for disagreement: I disagree with the team's judgement. As the tutor, they need the student's GitHub username to access or refer to their student's repos or just for administrative purposes. If the application allows two students to have the same GitHub account, it will hinder the tutor's job which defeats the purpose of the application to aid in the tutor's work.
Moreover, the team's argument of having unique emails and student numbers is sufficient to know whether a student is unique is irrelevant as my issue is not related to uniqueness of a student, but instead the correctness of the application with regard to checking the correctness of adding a student.
The app works as intended, however, shouldn't there be a check to check if a current GitHub username added is the same as a current student's GitHub username already. Allowing the same GitHub username to be added for two different students means that two people can have the same GitHub account.