nus-pe-bot
commented
2 years ago Team's Response
Inputting the same details will not change the output of the operation-- the student will still remain the same as before. There is a low chance of a user inputting the same information multiple times again and again, so such an error message to let the user know they reentered the same details is unnecessary.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: I disagree with the team's judgement on this. Their argument was that there is a low chance of a user inputting the same information multiple times again and again, but that does not mean that it will never happen. However, they fail to realize that users would not often double check that they had edited the person to the new correct information as they saw the command success message and take it as they did it right. That would mean that the person information is essentially wrong for the foreseeable future and the user would use this outdated information which is a problem.
Moreover the team stated, "Inputting the same details will not change the output of the operation-- the student will still remain the same as before.", which is the issue here, as the intention of the edit feature is to change the person's information, but the team themselves is agreeing that the person will remain the same in the event of the details is inputted wrongly which is the unintended outcome.
I am allowed to edit the details of a student with the exact same details again. There should be some check in place telling me the details are the same, if not a user can edit and accidentally input the same details when they mean to change a detail, and they would be unaware that they have reentered the same details.