Checking/unchecking the "Mash is SR" checkbox causes Fast Mode to increasingly update values by one extra unit in either direction (positive or negative) #7
I just somewhat figured how to isolate this piece of garbage that's been plaguing me for years.
When Fast Mode is activated, checking and unchecking and rechecking the "Mash is SR" checkbox will cause the incremental triggers for Servants to fire more than once at a time, thereby increasing the NP value by an additional unit per each time the checkbox state is changed. Example:
Seiba is at NP0
Activate Fast Mode or have it activated from before
Left click Seiba once > Seiba is now NP1
Change the state of the "Mash is SR" checkbox
Left click Seiba once > Seiba is now NP3
Left click Seiba one more time > Seiba is now NP5
Change the state of the "Mash is SR" checkbox again
Left click Seiba once > Seiba is now NP2 (rolls over counting to 0 > 1 > 2)
Left click Seiba one more time > Seiba is now NP5
Attached is a recording of the issue. I'm only using left clicks, which is why the jumps in value are so jarring. This applies going upwards (left clicking) as well as downwards (right clicking).
I THINK this might be due to something happening inside updateUserDataFast(), but I haven't fully understood Nechi's code that I inherited, so I can't 100% debug the issue with full knowledge of everything. Any help is appreciated.
I just somewhat figured how to isolate this piece of garbage that's been plaguing me for years.
When Fast Mode is activated, checking and unchecking and rechecking the "Mash is SR" checkbox will cause the incremental triggers for Servants to fire more than once at a time, thereby increasing the NP value by an additional unit per each time the checkbox state is changed. Example:
Attached is a recording of the issue. I'm only using left clicks, which is why the jumps in value are so jarring. This applies going upwards (left clicking) as well as downwards (right clicking).
I THINK this might be due to something happening inside
updateUserDataFast()
, but I haven't fully understood Nechi's code that I inherited, so I can't 100% debug the issue with full knowledge of everything. Any help is appreciated.https://github.com/user-attachments/assets/03273ee1-00d3-4193-b5f3-08b50cf15d8a