Toinane / colorpicker

A mininal but complete colorpicker desktop app
https://colorpicker.fr
GNU General Public License v3.0
1.55k stars 118 forks source link

[FR] color wheel based on picked color #60

Open farfromrefug opened 4 years ago

farfromrefug commented 4 years ago
Screen Shot 2020-02-20 at 17 05 40

When picking a color the wheel update to propose you colors related to the picked color.

I use that feature all the time. Would love to see that in your app.

Toinane commented 4 years ago

Hi @farfromrefug ! Thanks for your issue 🙂 If I understand, when you pick a color you have a colorwheel of colors that like the picked one. It is already available on Colorpicker no? When you open the tint menu, the first line is a colorwheel of colors that like the one you have on Colorpicker. If not can you precise it? What is the software you use on your screenshot? Thanks you! 😄

farfromrefug commented 4 years ago

@Toinane first thanks for the really fast answer :D Now yes it is similar to what you already do but it still seems different and is not what i expect.

Screen Shot 2020-02-20 at 20 57 14

I picked a color from the wheel. Now i expect to see similar colors in the sense that if i choose a pastel color the wheel (doesnt have to be a wheel :P ) give me different colors from the spectrum like you do but they should be at the same pastel level if i can say that. I think it is all based on HSL. And i think this article is talking about what i do. I think the wheel is only:

Seeing your code it seems to be what you do but the colors you show bug me. For example after picking the orange from the wheel the greens you show seem really "bright/flashy"

farfromrefug commented 4 years ago

Actually they might use a different formula. using this http://www.workwithcolor.com/hsl-color-schemer-01.htm?cp=3CFB59&ch=129-96-61&cm=0&sm=1&mil=0&dst=10 i seem to get the same as you

Toinane commented 4 years ago

Ahah thanks for the precision, yeah its like my colorwheel is a little bit buggy so! Okay I'll correct that for the next breaking update ! You can see #36 (yeah its now an old branch but I'll be more active now!)

Toinane commented 4 years ago

About curious, why you have [fr] in the title?

farfromrefug commented 4 years ago

fr is for feature request ;)

Toinane commented 4 years ago

Ohhh.. okay I was wondering if it was for french ahah! (Because French is my native language) I'll know for the next time thanks ahah

farfromrefug commented 4 years ago

@Toinane French is my native language too, bon a savoir :)

Toinane commented 4 years ago

Ahah effectivement ! On s'embête pour rien alors ! Bon c'est toujours plus agréable pour les autres s'ils veulent comprendre ce qu'on raconte !