search

Toinane / colorpicker

A mininal but complete colorpicker desktop app
https://colorpicker.fr
GNU General Public License v3.0
1.59k stars 119 forks source link

Color Discrepancy #90

Open jeremy-rifkin opened 3 years ago

jeremy-rifkin commented 3 years ago

Hello, I'm encountering a strange bug: the color picker tool is telling me that a color in an image is rgb (84, 85, 110), however, the photoshop eyedropper is telling me that the same color is rgb (84, 85, 108). Small difference, however, it's important for my use case.

The image is a png so I do not expect lossy compression to be a factor (although that shouldn't matter since the display color is what's being sampled). I do not believe the problem is related to the image viewing software I'm using as I've tested this in both photoshop and windows photos. I am also getting the issue with another color picker utility: Pipette.

This is a really weird bug and the issue very well may be on my end - either hardware or software. I am interested to know if anyone else has encountered a similar issue / knows the cause.

image

Toinane commented 3 years ago

Hey @jeremy-rifkin thank you for your issue! Yes its a know bug. Its due to the use of an external C++ module. It use a forced color space RGB that can be different of the color space used from your computer/monitor. Actually I can't do anything but use another C++ module or make my own (but I don't have the right knowledge for now)

Toinane commented 3 years ago

Actually Photoshop is also a problem, it use a particular color space, and I need to use the same color space to ensure to have the same RGB code from Photoshop. :/

jeremy-rifkin commented 3 years ago

@Toinane Thanks for the quick reply! Good to know the cause of the issue. I just tested two images, one RGB 8bit and one RGB 16bit. I am seeing the discrepancy only on the RGB 16bit image, which I think verifies that the problem is forced RGB color space. I would be interested in contributing to a C++ module that could resolve this issue, if possible.

Toinane commented 3 years ago

Oh okey, its good to know yeah! It would be amazing!! You can see my first attempt here: https://github.com/Toinane/native-picker It's based on https://github.com/mockingbot/mb_colorpicker_desktop_native But I want to use the N-api to make this C++ module more modulable with options like the grid size, show the previous colorpicker's color and others..