TokTok / c-toxcore

The future of online communications.
https://tox.chat
GNU General Public License v3.0
2.29k stars 287 forks source link

Retry bootstrap more than once #2042

Open iphydf opened 2 years ago

iphydf commented 2 years ago

Currently, bootstrap does:

The only data we store about the bootstrap call is the ping array entry. If that one and only sendpacket call fails or the packet is dropped, we never try again.

Instead, we should store the fact that we just tried to bootstrap, add this bootstrap node as a friend, and ping it until it gets thrown out the k-buckets.

emdee-is commented 9 months ago

From: https://github.com/TokTok/c-toxcore/issues/2469#issuecomment-1858986719

PS: Dear Santa: A version of add_tcp_relay that loops through a set of tcp nodes and loops until dht_connected is true is very high on my wish list.

What I find I have to do in my testrunner for Tor testing is to integrate add_tcp_relay loops of a random subset the tcpnodes into the testrunner after a check of if we are connected, as the connection may drop. It's a big problem running over Tor that you would not see in clearnet testing,