TokTok / c-toxcore

The future of online communications.
https://tox.chat
GNU General Public License v3.0
2.26k stars 285 forks source link

Three pkg-config files, only one installed #2334

Open ehmry opened 2 years ago

ehmry commented 2 years ago

There are three pkg-config files in the repo:

CMake is building and installing toxcore.pc, which doesn't look right.

zoff99 commented 1 year ago

@ehmry yes this is correct. the autotools and cmake build produce different results. autotools makes 3 libs, cmake puts everything into 1 lib.

autotools:

libtoxav.a
libtoxav.la
libtoxcore.a
libtoxcore.la
libtoxencryptsave.a
libtoxencryptsave.la
pkgconfig/libtoxav.pc
pkgconfig/libtoxcore.pc

cmake:

libtoxcore.a
libtoxcore.so
libtoxcore.so.2
libtoxcore.so.2.18.0
pkgconfig/toxcore.pc

cat pkgconfig/toxcore.pc
prefix=/usr/local
libdir=${prefix}/lib
includedir=${prefix}/include

Name: toxcore
Description: Tox protocol library
Requires.private: libsodium opus vpx
Version: 0.2.18
Libs: -L${libdir} -ltoxcore
Libs.private: -lpthread -lnsl -lrt
Cflags: -I${includedir}
zoff99 commented 1 year ago

you can see that cmake's toxcore.pc includes 'opus vpx' because its all in 1 lib. we wanted to sync autotools to also produce only 1 lib. but we didn't actually do that in the end.