TokTok / c-toxcore

The future of online communications.
https://tox.chat
GNU General Public License v3.0
2.21k stars 280 forks source link

fix: Zero out stack-allocated secret key before return. #2661

Closed iphydf closed 4 months ago

iphydf commented 4 months ago

Issue found by iphydf (no tools for this, yet).


This change is Reviewable

codecov[bot] commented 4 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f058103) 73.77% compared to head (dab5fe4) 73.70%.

Files Patch % Lines
toxcore/group_chats.c 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2661 +/- ## ========================================== - Coverage 73.77% 73.70% -0.08% ========================================== Files 148 148 Lines 30476 30478 +2 ========================================== - Hits 22485 22464 -21 - Misses 7991 8014 +23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.