Open iphydf opened 7 months ago
Attention: Patch coverage is 0%
with 28 lines
in your changes are missing coverage. Please review.
Project coverage is 73.05%. Comparing base (
77e0887
) to head (e8b2925
). Report is 41 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
toxcore/tox_api.c | 0.00% | 28 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Every error enum should have a conversion function to the canonical codes list. This can make client code more resilient to additions of error codes to per-function error enums, and simplify much of the error handling that currently needs to
switch()
over each error enum separately.It's still useful to have additional information from the per-function error enums to present the user with better error messages, but for programmatic error handling (e.g. bots), the canonical codes should always be sufficient context.
This change is