search

TokTok / c-toxcore

The future of online communications.
https://tox.chat
GNU General Public License v3.0
2.21k stars 280 forks source link

feat: add message IDs to private group messages #2727

Closed JFreegman closed 3 months ago

JFreegman commented 3 months ago

This change is Reviewable

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 73.13%. Comparing base (99e0bcc) to head (7b1db6a).

Files Patch % Lines
toxcore/tox.c 30.76% 9 Missing :warning:
toxcore/events/group_private_message.c 54.54% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2727 +/- ## ========================================== + Coverage 73.05% 73.13% +0.07% ========================================== Files 149 149 Lines 30499 30516 +17 ========================================== + Hits 22282 22317 +35 + Misses 8217 8199 -18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Green-Sky commented 3 months ago

you need to adjust the event here: https://github.com/TokTok/c-toxcore/blob/b3c3c49d26c0cf2b91b9ec69f9a3f932ab9f2d6d/other/event_tooling/generate_event_c.cpp#L744-L761

Green-Sky commented 3 months ago

@JFreegman commit message is wrong, needs to be messages, not packets.