Closed nurupo closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.08%. Comparing base (
5344d7f
) to head (102a1fa
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Circle CI's image got updated to use Ubuntu 24.04 (Noble Numbat), which:
libclang_rt.ubsan_standalone-x86_64.a
is no longer getting installedIncludes a newer clang with more enabled warnings in one the umbrella flags like -Weverything, -Wall, etc., like
-Wswitch-default
and-Wunsafe-buffer-usage
:-Wswitch-default
should be disables-Wunsafe-buffer-usage
seems to be broken, it warns on things that are perfectly ok, like doingfoo[1] = 0;
whereuint32_t foo[4];
, e.g.warning:
on:
https://github.com/TokTok/c-toxcore/blob/da438763d5b8e071de6e061a1dcaddd2177dff7d/toxcore/network.c#L966
where
uint32
is:https://github.com/TokTok/c-toxcore/blob/da438763d5b8e071de6e061a1dcaddd2177dff7d/toxcore/network.h#L200
This change is